plusplusjiajia commented on code in PR #758:
URL: https://github.com/apache/paimon-rust/pull/758#discussion_r3995308366
##########
crates/paimon/src/table/table_commit.rs:
##########
@@ -205,7 +205,7 @@ impl TableCommit {
filter_committed: bool,
) -> Result<()> {
// A commit validates against the existing snapshot.
-
CoreOptions::new(self.table.schema().options()).ensure_read_authorized()?;
+ self.table.ensure_read_authorized_live("a commit").await?;
Review Comment:
@JingsongLi You're right that the commit check comes too late.
write_arrow_batch and prepare_commit now ask before the writer's first lazy
read, so the snapshot scan and the hash-index load sit behind it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
