JingsongLi commented on PR #758: URL: https://github.com/apache/paimon-rust/pull/758#issuecomment-5831788703
Re-reviewed head `62823d6e` after the author's reply. Requirement fit: SUPPORTED. The earlier literal-`$` table-name regression is fixed: `RESTCatalog` no longer rejects the name during load, and the new test covers both a plain literal name and refusal of a protected decorated view. I traced the grant from REST authorization through scan planning, split marking, and read materialization, including the restricted-response, nested-field, stale-handle, and count-pushdown paths. I found no new actionable code finding on this head. Local validation: 15/15 REST query-auth integration tests, 29/29 matching core unit tests, and 14/14 DataFusion partition-count tests passed; formatting and diff checks passed. All 14 CI checks are green. The first local REST run failed only because the sandbox denied the mock server's socket bind; the same suite passed when run with socket permission. **Integration follow-up before merge:** this head currently conflicts with main in `crates/paimon/src/table/rest_env.rs` and `crates/paimon/tests/mock_server.rs` (`git merge-tree --write-tree main HEAD`). Please rebase and rerun the REST authorization and DataFusion fallback suites on the resolved result. The tests above validate this PR head, not a conflict resolution. The documented plan-time authorization limitation remains part of the proposed contract and should be stated prominently for production callers that retain plans across permission changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
