TheR1sing3un opened a new pull request, #9755:
URL: https://github.com/apache/paimon/pull/9755

   ### Purpose
   
   Vector index searches may raise synchronously before returning a Future, for 
example when a query has the wrong dimension or index I/O fails. The completion 
callback was registered only after that call, leaving the opened reader 
unclosed on this path.
   
   Close the reader when single or batch search raises synchronously. Searches 
that return a Future retain their existing completion-based cleanup.
   
   ### Tests
   
   - Added a regression covering single and batch search with synchronous 
failure, pending success, pending failure, and an already-completed Future. It 
verifies that the reader and stream close exactly once and remain open while 
work is pending. The synchronous-failure case fails on the original code.
   - `python -m pytest pypaimon/tests/vector_search_filter_test.py 
pypaimon/tests/vindex_vector_index_test.py -q`: 79 passed.
   - Flake8 with `dev/cfg.ini` and `git diff --check` passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to