wangyong9999 commented on PR #314: URL: https://github.com/apache/paimon-cpp/pull/314#issuecomment-5646583241
Follow-up review completed at 016a9747. I found no additional production defect in the retained changes, but closed two validation gaps: the 1,025-row-group test checks index retention/release and decoding after the cache limit; the 1,001-page test checks every returned value under sparse/dense selection, coalesce/trim and both pre-buffer settings. Trim deliberately includes gaps within a selected page, so its oracle differs from exact bitmap selection. Results: Parquet 228/228, read integration 294/294, read-with-index integration 68/68; full pre-commit and diff checks passed. The production implementation is unchanged by this follow-up. Both original review threads remain resolved. Performance limitations and draft status remain unchanged; these additional tests are correctness evidence, not a new speedup claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
