lxy-9602 commented on code in PR #314:
URL: https://github.com/apache/paimon-cpp/pull/314#discussion_r4033706184
##########
src/paimon/format/parquet/file_reader_wrapper.h:
##########
@@ -60,7 +60,7 @@ class FileReaderWrapper {
static Result<std::unique_ptr<FileReaderWrapper>> Create(
std::unique_ptr<::parquet::arrow::FileReader>&& reader, int64_t
batch_size,
- std::shared_ptr<arrow::MemoryPool> pool);
+ std::shared_ptr<arrow::MemoryPool> pool, bool
enable_offset_index_cache = false);
Review Comment:
I believe we may have mentioned similar comments in previous PRs as well. To
keep the production code style consistent, could we avoid default arguments,
and when adding non-output parameters, keep `pool` as the last parameter?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
