thswlsqls opened a new pull request, #9868:
URL: https://github.com/apache/paimon/pull/9868

   ### Purpose
   
   fix #9867
   
   - `AbstractFileStore.newTagManager()` used `DEFAULT_MAIN_BRANCH`, while 
`snapshotManager()` and `AbstractFileStoreTable.tagManager()` honor 
`options.branch()`. Pass `options.branch()`; main tables are unaffected.
   - Branch tables: `ExpireSnapshotsImpl` now protects tagged snapshots instead 
of deleting their manifest list and data files.
   - Flink `rollback_to` / `rollback_to_as_latest` and Spark `rollback` 
procedures find branch tags.
   - Automatic tags and `_SUCCESS` files land in the branch `tag/` directory.
   - Same pattern as #9044 (`StaticFromTagStartingScanner`); the main-branch 
default dates from #3029.
   
   ### Tests
   
   - Added `PrimaryKeySimpleTableTest#testExpireSnapshotsKeepsBranchTag`: tags 
a branch snapshot, expires to one snapshot, asserts store and table tag 
directories match and the tag stays readable. Without the fix the directories 
differ and, past that assertion, the tag read hits `FileNotFoundException` on 
the manifest list.
   - `mvn -pl paimon-core -Dtest=PrimaryKeySimpleTableTest test` — 136 tests 
passed.
   - `mvn -pl paimon-core clean install` (checkstyle, spotless, enforcer, 
surefire) — 5437 tests, 0 failures; only `PostgresqlCatalogTest` (needs Docker) 
could not start locally.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to