JingsongLi commented on PR #9868: URL: https://github.com/apache/paimon/pull/9868#issuecomment-5708356690
Correct fix. `newTagManager()` hardcoded `DEFAULT_MAIN_BRANCH` while the rest of the store resolves `options.branch()`, so on a branch table tags were created/expired under the main branch's tag directory — expiring on the branch (or reading tags through the branch) then missed them. I verified this was the last hardcoded-main-branch `TagManager` construction site; passing `options.branch()` makes it consistent. The test asserting the tag directory matches `branchTable.tagManager()`'s and that tagged data survives `expireSnapshots()` captures the user-visible symptom nicely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
