wangyong9999 commented on code in PR #314:
URL: https://github.com/apache/paimon-cpp/pull/314#discussion_r4038367546
##########
src/paimon/format/parquet/file_reader_wrapper.h:
##########
@@ -60,7 +60,7 @@ class FileReaderWrapper {
static Result<std::unique_ptr<FileReaderWrapper>> Create(
std::unique_ptr<::parquet::arrow::FileReader>&& reader, int64_t
batch_size,
- std::shared_ptr<arrow::MemoryPool> pool);
+ std::shared_ptr<arrow::MemoryPool> pool, bool
enable_offset_index_cache = false);
Review Comment:
Fixed in 38acb1c2.
- Removed the default argument from `FileReaderWrapper::Create`.
- Moved `enable_offset_index_cache` before `pool` in the declaration,
definition and all callers; `pool` is now last.
- The read option still defaults to false; runtime behavior is unchanged.
Validation: Parquet 227/227 passed; changed-file pre-commit and diff checks
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
