JingsongLi commented on PR #9438: URL: https://github.com/apache/paimon/pull/9438#issuecomment-5748014722
Requirement fit: PIVOT (the bug is real, but this implementation does not address it). Implementation: FINDINGS. The current head is still the original single commit. `checkGlobalIndexConflicts` only parses `schema.options()` keys beginning with `global-index`; standard Global Index definitions are stored in the latest snapshot's index manifest, so the indexed-field set is normally empty and the DROP COLUMN from #9419 still succeeds. The method also catches every exception and returns, making the safety guard fail open. There is no production-path regression test, and the current CI matrix is red. The discussion already identifies the necessary implementation: construct the branch-specific table, scan the latest snapshot through `newIndexFileHandler()`, resolve `GlobalIndexMeta` field IDs, propagate read failures, and test a real committed index before/after dropping it. Since none of that code has been pushed and the present patch has no end-to-end protective effect, I am closing this PR. Please open or reopen a focused implementation once that manifest-backed, fail-closed path is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
