JingsongLi commented on PR #8631: URL: https://github.com/apache/paimon/pull/8631#issuecomment-5748064585
I reviewed the current core-only head and the earlier correctness findings. **Requirement fit: SUPPORTED. Code review: CLEAN.** Using the normal `COMPACT` commit path for sort compaction removes the special `OVERWRITE` semantics and addresses a real correctness/maintainability problem, especially around deletion vectors. The current implementation covers the previously raised blockers: - rewritten compact messages are tied to base deletion-vector metadata and abort paths clean up both original and rewritten outputs; - concurrent deletion-vector changes are not silently restored; - delete-only compaction success is not inferred from an empty data-file set, and the tests cover the conflicting/concurrent-compaction case. The core PR is now separated from engine wiring, and the current CI is green. I found no additional actionable correctness issue in this head. The stacked engine integration in #9790 should remain dependent on this core contract and be merged only after this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
