jerry-024 commented on code in PR #110:
URL:
https://github.com/apache/paimon-vector-index/pull/110#discussion_r4059576768
##########
include/paimon_vindex.hpp:
##########
@@ -669,6 +815,21 @@ class Reader {
}
Review Comment:
<!-- dlf-review -->
**[Minor] Remove the duplicate wrapper-side range validation**
All four C++ range-search entry points call this helper, which performs an
extra metadata FFI call and repeats the overflow, length, and null checks
already enforced by the shared C ABI path in ffi/src/range.rs. Keeping both
paths adds a boundary call and creates two validation sources that can drift.
Please delete this helper and its four call sites, keep the raw result
initialized to null, and rely on the existing C ABI error plus
check/copy_range_result path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
