zhangweilst commented on PR #373: URL: https://github.com/apache/paimon-cpp/pull/373#issuecomment-5760628454
> Thanks a lot for the fix. Could you also create a corresponding issue for this PR to describe the problem? > > I’d also like to better understand your use case: are you using your own Parquet reader in your environment? It seems the default Parquet reader would not return a dictionary for the binary type. > > Also, there appear to be several places in the current codebase that forcibly assume a string dictionary, which may have similar issues. Would you prefer to address those in this PR as well, or leave them for follow-up PRs? We're indeed using an internal parquet reader for performance trade-offs, which will read the dictionary encoded binary into a dictionary. But the default parquet reader can also be possible to end up with a dictionary if there're `ARROW:schema` meta data in the parquet footer. It's not a common scenario though. I guess I can address those 'forcibly assume a string dictionary' issues in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
