zhangweilst commented on code in PR #373:
URL: https://github.com/apache/paimon-cpp/pull/373#discussion_r4119669592
##########
src/paimon/format/parquet/parquet_file_batch_reader_test.cpp:
##########
@@ -1983,11 +2101,8 @@ TEST_F(ParquetFileBatchReaderTest,
TestDictionaryPassthrough) {
}
TEST_F(ParquetFileBatchReaderTest, TestDictionaryPassthroughSkipsBinaryColumn)
{
- // Parquet stores STRING and BINARY in the same BYTE_ARRAY leaf and
dictionary-encodes both, so
- // the gate has to exclude BINARY by logical type. It does, because
nothing downstream can read
- // `dictionary(int32, binary)`: ColumnarUtils::GetView() asserts on it and
returns an empty view
- // in a release build, and LiteralConverter rejects it. `f8` is the
control - same physical
- // type, same pages, and it is forwarded - so this fails if the exclusion
is ever widened back.
+ // Keep the passthrough policy limited to STRING even though consumers
also support binary
+ // dictionaries. Both columns use BYTE_ARRAY and dictionary pages; f8 is
the STRING control.
Review Comment:
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
