JingsongLi commented on PR #882: URL: https://github.com/apache/paimon-rust/pull/882#issuecomment-5771902662
Reviewed head b75b8b91. Requirement fit: SUPPORTED; implementation: FINDINGS. **[P1] Preserve the already-merged precision-zero timestamp path when rebasing.** Main commit d05cb03a (#884) changed `TIMESTAMP(0)` / `TIMESTAMP_LTZ(0)` Arrow leaves to `TimeUnit::Second` and added the corresponding reader arm. This head still maps `0..=3` to milliseconds in `timestamp_array` and has no Second arm in `timestamp_value_at`; merging either side without reconciling them will write the wrong unit or fail to read precision-zero shredded values. GitHub currently marks this PR CONFLICTING. Please rebase, add explicit seconds↔micros conversion, and cover precision 0 on both read and write. Separately, the disclosed legacy-file incompatibility needs a concrete migration/compatibility decision: files previously written with explicit precision 1–3 or 7–9 schemas contain micros under a millis/nanos annotation and have no distinguishing marker, so the new reader will silently reinterpret persis ted typed values. A fixture from the old writer plus documented handling (for example an explicit legacy mode or required rewrite) would make that impact reviewable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
