jackylee-ch commented on PR #882: URL: https://github.com/apache/paimon-rust/pull/882#issuecomment-5882673034
Closing in favor of #983. This PR rescales the shredded timestamp to the column's declared precision, but the Parquet Variant shredding spec requires a shredded timestamp `typed_value` to be MICROS or NANOS, so a MILLIS/SECOND leaf is not spec-conformant and the rescale also drops sub-millisecond precision. #983 pins the shredded `typed_value` to microseconds instead, which removes the precision loss entirely (microseconds are stored as-is) and needs no data migration: files written by the earlier code stored the raw microsecond value and the reader reads it back unchanged, while new files are now correctly annotated for other engines. Thanks for the detailed review — the microsecond approach in #983 resolves both blockers raised here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
