Akash3121 commented on code in PR #10124:
URL: https://github.com/apache/paimon/pull/10124#discussion_r4078172470
##########
paimon-python/pypaimon/tests/test_format_row_reader_writer.py:
##########
@@ -88,6 +88,44 @@ def test_basic_int_string(self):
finally:
os.unlink(path)
+ def test_high_precision_decimal(self):
Review Comment:
Nit, not a blocker
This test changes the writer and reader together, so a symmetric scaling
mistake in both paths could still round-trip successfully. Since row files are
shared with the Java implementation, could we add one independent assertion -
either decode a hand-built signed unscaled byte sequence for DECIMAL(38, 10) ,
or inspect the writer’s encoded bytes and compare them with the exact expected
unscaled integer? That would directly protect cross-language wire compatibility
rather than only the Python writer/reader pair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
