JingsongLi commented on PR #10124: URL: https://github.com/apache/paimon/pull/10124#issuecomment-5805905782
This fixes silent high-precision DECIMAL corruption in the row format. I reviewed both write-side unscaled conversion and read-side rescaling under `localcontext`; the context width covers the declared precision/scale, and the low-precision wire branch remains intact. The independent hand-built wire test addresses the earlier cross-language compatibility comment. Local verification on the PR patch: all 27 `test_format_row_reader_writer.py` tests passed, including the positive/negative/null DECIMAL round-trips and raw-wire assertion. The current PR checks remain red in Python 3.10–3.13 (plus the aggregate result). Please resolve those matrix failures or establish an unrelated cause before production merge. This has clear end-to-end data-integrity value, and I found no blocking defect in the changed decimal conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
