lxy-9602 commented on code in PR #384:
URL: https://github.com/apache/paimon-cpp/pull/384#discussion_r4080994733
##########
src/paimon/core/realtime/realtime_append_only_writer.cpp:
##########
@@ -121,27 +121,29 @@ Status
RealtimeAppendOnlyWriter::Write(std::unique_ptr<RecordBatch>&& batch) {
Status RealtimeAppendOnlyWriter::SealCurrentSegment() {
PAIMON_ASSIGN_OR_RAISE(std::optional<std::shared_ptr<RealtimeSegmentHandle>>
segment,
realtime_store_->SealForCommit());
- if (segment) {
- if (!segment.value()) {
- return Status::Invalid("append real-time store sealed a null
segment");
Review Comment:
Please also update the interface comment in `realtime_store.h` — “Paimon
serializes calls to Write and SealForCommit for the same store.” Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
