HaHaJeff commented on code in PR #384:
URL: https://github.com/apache/paimon-cpp/pull/384#discussion_r4081184690
##########
src/paimon/core/realtime/realtime_append_only_writer.cpp:
##########
@@ -121,27 +121,29 @@ Status
RealtimeAppendOnlyWriter::Write(std::unique_ptr<RecordBatch>&& batch) {
Status RealtimeAppendOnlyWriter::SealCurrentSegment() {
PAIMON_ASSIGN_OR_RAISE(std::optional<std::shared_ptr<RealtimeSegmentHandle>>
segment,
realtime_store_->SealForCommit());
- if (segment) {
- if (!segment.value()) {
- return Status::Invalid("append real-time store sealed a null
segment");
Review Comment:
Updated in commit dc745fe91932dc2cba919fb13639dfc427280006. The interface
comment now reflects possible Write/SealForCommit overlap and store-side
synchronization of segment rotation. After rotation, subsequent writes go to
the new building segment while the sealed segment may be spilled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
