JingsongLi commented on PR #10125:
URL: https://github.com/apache/paimon/pull/10125#issuecomment-5805895181

   This fixes a user-visible timestamp decode error in the row format: the 
integer returned by `_read_field` must use the Arrow unit selected for the 
declared precision. I checked the wire layout and the 
seconds/milliseconds/microseconds/nanoseconds formulas, including the 
hand-built sub-microsecond `nano_of_milli` case. The file format itself is 
unchanged.
   
   Local verification on the isolated PR patch: all 27 
`test_format_row_reader_writer.py` tests passed. The current PR checks remain 
red in Python 3.10–3.13 (plus the aggregate result), so please determine their 
cause and get the required matrix green before a production merge. This has 
clear end-to-end correctness value; I found no blocking defect in the changed 
decode formula.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to