jackylee-ch commented on PR #10164: URL: https://github.com/apache/paimon/pull/10164#issuecomment-5825508061
Thanks @Akash3121 — both addressed (rebased onto master): 1. Added an `isinstance(_, Predicate)` guard in `_materialise`, so `with_filter(object())` again raises the documented `NotImplementedError`, not an `AttributeError` (fixes `test_filter_is_not_supported_yet`). 2. Added `_reject_non_scalar_filter_fields`: comparisons / is-in on non-scalar columns (`write_cols`, `dv_ranges`) now raise the documented `NotImplementedError` up front (null checks still pushed down). Added regression tests for an array column and the non-Predicate case; `tests/system` green (93 passed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
