JingsongLi commented on PR #10164:
URL: https://github.com/apache/paimon/pull/10164#issuecomment-5831952474
Reviewed the current head end to end. This fixes an existing public
`with_filter` path that always failed for system tables, so it has direct value
for catalog users and integrations that push down filters. The implementation
checks Arrow-safe methods, rejects value comparisons on nested system columns
with a clear error, applies the filter before projection, and retains the
documented rejection for non-`Predicate` objects and string-match predicates.
The two issues raised in the earlier review are addressed at this head.
Verification: all 93 system-table tests passed locally, and `git diff
--check` passed. I also seeded a real catalog-backed `db.t$snapshots` table
with two snapshots, filtered `snapshot_id = 2` while projecting only
`commit_user`, and got exactly `[{"commit_user": "bob"}]`. CI is green across
the scheduled Python versions and Native CI. I found no blocking regression.
Comparisons on nested fields and string-match filters remain unsupported by
design and report that explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
