TheR1sing3un commented on code in PR #10166:
URL: https://github.com/apache/paimon/pull/10166#discussion_r4101818355
##########
paimon-python/pypaimon/write/writer/key_value_data_writer.py:
##########
@@ -286,6 +295,11 @@ def _sort_by_primary_key(
# Table, so this serves both the per-batch entry path (legacy)
# and the buffer-wide sort path (used by ``_flush_all``).
sort_keys = [(key, 'ascending') for key in self.trimmed_primary_keys]
+ sequence_fields = self.options.sequence_field()
Review Comment:
It has been fixed. Thank you for your suggestion！
##########
paimon-python/pypaimon/tests/test_sequence_field_read.py:
##########
@@ -301,7 +302,8 @@ def test_missing_sequence_field_rejected(self):
"""
table = self._create_pk_table(
Review Comment:
It has been fixed. Thank you for your suggestion！
##########
paimon-python/pypaimon/write/writer/key_value_data_writer.py:
##########
@@ -45,6 +45,15 @@ def __init__(self, table, partition, bucket, max_seq_number,
changelog_producer=ChangelogProducer.NONE):
super().__init__(table, partition, bucket, max_seq_number,
options, write_cols, changelog_producer)
+ if self.options.sequence_field():
Review Comment:
It has been fixed. Thank you for your suggestion！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
