JingsongLi commented on PR #10165: URL: https://github.com/apache/paimon/pull/10165#issuecomment-5831916111
Reviewed the current head as a data-loss prevention change. It has standalone end-to-end value for unsupported aggregation configurations: writer construction now fails before a row can enter the buffer or dynamic-bucket extractor, so a later read error cannot be the first indication that input was discarded. I checked the construction order (`FileStoreWrite` precedes row-key extraction), the native dispatch (aggregation is excluded from native writes), and the read-side option guard reused here. Explicitly false retract flags remain accepted by the write guard. Local verification: 91 relevant aggregation, partial-update, sequence, write-buffer, and native-dispatch tests passed; 14 optional-Rust cases were skipped and 4 subtests passed. The current CI is green for Native CI and all scheduled Python versions. The earlier dynamic-bucket side-effect and false-flag test issues have been addressed at this head. No new blocker found in this guard. Production scope to keep visible: this PR does **not** make normal aggregation writes safe by itself. `FileStoreWrite._build_pk_merge_function` still falls back to deduplicate for otherwise supported aggregation configurations; #10162 is needed for actual aggregation write semantics. Please keep that dependency explicit in the merge decision and add a supported-aggregation write/read smoke test with the final combined behavior. The false-valued retract case is currently tested for write acceptance only, because native read validation remains a separate compatibility gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
