JingsongLi commented on PR #10105: URL: https://github.com/apache/paimon/pull/10105#issuecomment-5832418463
Re-reviewed latest head `27290b3` for production, focusing on the new chain-table overwrite replay path after the earlier Spark streaming idempotency reviews. The previous equal-timestamp cross-branch bug is addressed: the delta overwrite now records the snapshot branch's exact snapshot ID before publication, and retry uses that position instead of comparing independent branch clocks. The retry follows subsequent file rewrites and fails closed when the position has expired or old/new data can no longer be separated. Local JDK 8 `ChainTableFileStoreTableTest` passed 57/57, including failed cleanup, later snapshot-branch writes, compaction, the equal-timestamp regression, and missing-position cases. The Spark 3 and Spark 4 CI jobs pass on this head. Core CI is red only because `S3FileIOTest` could not pull its MinIO Docker image (both JDK 8 and 11), not because a changed-path test failed; please rerun those jobs before merge. `git diff --check` passed. I found no new code blocker in this follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
