JingsongLi commented on PR #10322: URL: https://github.com/apache/paimon/pull/10322#issuecomment-5934293794
Review of `663b06378c`: the Python permission-management port has useful end-to-end value. I ran the 21 new tests and 61 existing REST tests (plus 6 subtests); all passed. Changed files also passed Flake8 and Python 3.6 grammar checks. **[P2] Preserve encoded catalog prefixes in the new permission routes** At `pypaimon/api/resource_paths.py:144-151`, all three new routes reuse an unencoded `base_path`. With the accepted catalog prefix `catalog/id`, the actual client sends: ```text GET /v1/catalog/id/permissions?resourceType=CATALOG POST /v1/catalog/id/permissions/grant POST /v1/catalog/id/permissions/revoke ``` The Java permission-management contract requires `/v1/catalog%2Fid/permissions...`; this is explicitly covered by `ResourcePathsTest#testPermissionManagementUsesPrefix`. I reproduced all three Python operations against a local HTTP server implementing that route, and each raised `NoSuchResourceException` (404). The raw-prefix helper predates this PR, so this is an incomplete acceptance case for the newly added Java port, rather than a regression to existing Python operations. Please encode the prefix as one path segment and port the encoded-prefix assertions/HTTP cases for list, grant and revoke. The new HTTP tests currently use only `prefix="catalog"`, which misses this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
