jackylee-ch commented on PR #977: URL: https://github.com/apache/paimon-rust/pull/977#issuecomment-5944534547
Addressed. `RESTCatalog::alter_table` now ignores only `TableNotExist` under `ignore_if_not_exists`, matching `FileSystemCatalog` and the `Catalog::alter_table` contract (it is the `ALTER TABLE IF EXISTS` *table* flag). A `ColumnNotExist` from an existing table — a dropped-missing column, or a batch the server rejects atomically — now surfaces instead of being reported as success. The new `COLUMN` resource-type mapping (`ColumnNotExist`/`ColumnAlreadyExist`) is retained. Updated the e2e test accordingly: dropping a missing column with `ignore_if_not_exists = true` on an existing table now returns `ColumnNotExist` (no longer swallowed), and I added your batch case — `[ADD COLUMN extra, DROP COLUMN ghost]` fails with `ColumnNotExist` and a reload shows `extra` was not persisted (the server rejected the batch atomically). I verified non-vacuity: re-adding `ColumnNotExist` to the swallow set makes the drop return `Ok` and the test fail; ignoring only `TableNotExist` passes. Rebased onto current main. The REST-server e2e tests pass; `clippy -p paimon -p paimon-rest-server --all-targets -D warnings` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
