jackylee-ch commented on PR #10179:
URL: https://github.com/apache/paimon/pull/10179#issuecomment-5954177612
Fixed in 6d07ffddc. OVERLAY's `pos - 1` and `pos + replaced` are now wrapped
to signed 32-bit before indexing, matching `OverlayTransform`'s Java `int`
arithmetic, so a boundary position overflows the same way.
`OVERLAY('hello','x',1,2147483647)` now returns `xhell` (the wrapped end lands
inside the string) instead of `x`, so the auth rule admits the same rows as
Java.
Added `test_overlay_position_arithmetic_overflows_like_java`; reverting the
wrap makes it return `x`, so it's non-vacuous. If Java's overflow is itself
later corrected, this should follow it — the wrap just keeps the two
implementations in agreement today. flake8 and `git diff --check` clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
