jackylee-ch commented on PR #1021: URL: https://github.com/apache/paimon-rust/pull/1021#issuecomment-5980785667
Thanks for the review — all findings addressed in the latest commit (CI re-running). - **Source namespace [P1]**: CTAS no longer overrides the session's default catalog/database before inference; the source query is expanded, inferred, and populated in the one session namespace, so a cross-database `source` can't be inferred while the session's rows are inserted positionally. - **Target quoting [P1]**: every INSERT identifier is now quoted/escaped, so a case-sensitive target like `"Dst"` is written as created, not normalized onto a different existing table. - **Population cleanup [P2]**: a failed population drops the table this statement created and surfaces the original error, so a corrected IF NOT EXISTS retry populates instead of no-opping on a leftover. - **Existence check [P2]**: IF NOT EXISTS uses the load path and treats only `TableNotExist` as absence, so an existing engine-served table is a no-op, not a failed populate. Added FileSystemCatalog-backed tests for each; each fails if its fix is reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
