Stephen0421 commented on code in PR #10114:
URL: https://github.com/apache/paimon/pull/10114#discussion_r4213878416
##########
paimon-python/pypaimon/write/commit_message.py:
##########
@@ -41,6 +41,7 @@ class CommitMessage:
compact_changelog_files: List[DataFileMeta] = field(default_factory=list)
compact_index_adds: List['IndexManifestEntry'] =
field(default_factory=list)
compact_index_deletes: List['IndexManifestEntry'] =
field(default_factory=list)
+ preserve_blob_files_on_abort: bool = False
Review Comment:
This is not part of the v14 commit message and is not written to disk.
`TableCommit.abort` only receives `CommitMessage`s, not the writer, so it
cannot see whether `prepare_commit` ran with a `BlobConsumer`.
Without the flag, abort cannot tell an uncommitted `.blob` pack (which must
be deleted) from a pack whose descriptor was already handed to the consumer
(which must stay). `writer.abort()` still has the consumer and does not use
this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
