JingsongLi commented on PR #10114:
URL: https://github.com/apache/paimon/pull/10114#issuecomment-6151985677

   Reviewed current head `c4e0eef621536f289a5157b781e0220731b6e0ed` against its 
actual merge base (`3d63e411`). No newly introduced correctness defect was 
found. 223 focused Python tests and 4 Java sidecar tests passed; an actual 
Python-write→Java-read and Java-write→Python-read probe also passed for CJK, 
supplementary Unicode, NUL and UTF-16 surrogate metadata.
   
   Closing under the requested end-to-end value gate for the remaining 
standalone scope. The prepare ownership handoff, BlobConsumer writer-abort 
protection, explicit commit-abort deletion and ordinary `.row` sidecar cleanup 
are already present in the merge base. The main new collector/`.blobref` 
library has no production writer caller or `extra_files` registration. The 
residual abort changes concern malformed/custom metadata or nonconforming 
deletion implementations; supported FileIO implementations already suppress 
deletion exceptions. The UTF validation improves defensive consistency, but no 
actual producer/read failure was established for this PR.
   
   Please combine the collector with the follow-up PK writer integration, 
sidecar registration and GC reachability/readback tests, and update the 
description to match the final ownership semantics. Reopening a change that 
demonstrates that complete path is welcome. This closure is a scope/value 
decision, not a claim that the format implementation is incorrect.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to