jackylee-ch commented on code in PR #1042:
URL: https://github.com/apache/paimon-rust/pull/1042#discussion_r4358211699
##########
crates/paimon/src/table/table_read.rs:
##########
@@ -776,10 +776,21 @@ impl<'a> PaimonTableRead<'a> {
}
}
}
- // Delta / Changelog rows are read as-is from planned files (no
full-table
- // merge against historical base versions).
+ // Delta / Changelog rows are read as-is from planned files, without a
merge
+ // against historical base versions. Files are still decoded as an
ordinary
+ // read decodes them: primary-key BLOB descriptors resolve to
payloads, and
+ // data-evolution files in a split that hold column slices of the same
rows
+ // merge by row id.
let data_splits = self.matching_splits(&data_splits)?;
- self.new_data_file_reader()?.read(&data_splits)
+ let core_options = self.table.schema().core_options();
+ if !self.table.schema().primary_keys().is_empty() {
+ return self
+ .resolving_primary_key_blobs(&core_options, |read|
read.read_raw(&data_splits));
+ }
+ if core_options.data_evolution_enabled() {
+ return self.read_with_evolution(&data_splits, &core_options);
Review Comment:
Fixed in 8f26c02: change events merge a row-id group only when its files are
column slices of one row range; others, like this VECTOR-only update, are
decoded file by file. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
