Akash3121 commented on code in PR #10755:
URL: https://github.com/apache/paimon/pull/10755#discussion_r4369817825
##########
paimon-core/src/main/java/org/apache/paimon/index/pk/BucketedPrimaryKeyIndexMaintainer.java:
##########
@@ -55,16 +57,16 @@
/** Coordinates all source-backed primary-key indexes for one bucket. */
public final class BucketedPrimaryKeyIndexMaintainer {
- @Nullable private final BucketedVectorIndexMaintainer vectorMaintainer;
+ private final List<BucketedVectorIndexMaintainer> vectorMaintainers;
Review Comment:
`PrimaryKeyIndexWriteTest.testCreatesCoordinatorForMultipleScalarDefinitionsAndVector`
still reflects the old `vectorMaintainer` field name. Because this field was
renamed to `vectorMaintainers`, both the JDK 8 and JDK 11 Core CI jobs fail
with `NoSuchFieldException` at `PrimaryKeyIndexWriteTest.java:142`. Please
update the test to read the list field, assert its expected size, and use the
appropriate list element when checking `deletionVectorFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
