tzphh commented on code in PR #10755:
URL: https://github.com/apache/paimon/pull/10755#discussion_r4386141023
##########
paimon-core/src/main/java/org/apache/paimon/index/pk/BucketedPrimaryKeyIndexMaintainer.java:
##########
@@ -55,16 +57,16 @@
/** Coordinates all source-backed primary-key indexes for one bucket. */
public final class BucketedPrimaryKeyIndexMaintainer {
- @Nullable private final BucketedVectorIndexMaintainer vectorMaintainer;
+ private final List<BucketedVectorIndexMaintainer> vectorMaintainers;
Review Comment:
Fixed in the updated CR2 head 7136275025, which includes the corrected
prerequisite. The test reads `vectorMaintainers` as a list, checks its single
entry, and retains the deletion-vector factory assertion. All 69 focused Core
tests passed locally on this head (JDK 17).
I also verified the combined head e787eb7f96, which includes CR1 and CR2, on
JDK 8 (1.8.0_512) and JDK 11 (11.0.27). All 139 focused Core tests passed on
each runtime, including this regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
