skyyyy955 opened a new pull request, #10804:
URL: https://github.com/apache/paimon/pull/10804

   ### Purpose
   
   Correct the `set-option` and `remove-option` examples to use 
`snapshot.num-retained.max`. The previous spelling, 
`snapshot.num-retained-max`, changes a different schema option and leaves the 
actual snapshot-retention option untouched.
   
   The examples come from Jingsong Lee's documentation reorganization in #9726 
(`1f68a07c8cb`). This changes two examples; no option definition or runtime 
behavior changes.
   
   ### Tests
   
   At `e2cdaf54`, exercised both original and corrected examples through the 
table subcommand parser and handler with a real filesystem catalog, reopening 
it after each command. The corrected examples set and remove the canonical 
option. The shared probe had an unrelated ROW writer patch; the 
CLI/catalog/schema files matched the base, and no row data was written. 
Snapshot expiration itself was not exercised.
   
   Both documentation variants passed a frozen-lockfile installation and full 
production build with Node 20.20.2 / Yarn 1.22.22, including REST OpenAPI 
validation. Checked the corrected page in Chrome at desktop and mobile widths, 
including horizontal scrolling of both commands. These were local checks; the 
GitHub Actions documentation job remains pending.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to