lxy-9602 commented on code in PR #374:
URL: https://github.com/apache/paimon-cpp/pull/374#discussion_r4374217567
##########
src/paimon/core/operation/file_store_scan.h:
##########
@@ -289,8 +293,10 @@ class FileStoreScan {
/// Read request-filtered entries while caching complete bucket snapshots.
/// @return Number of entries considered before request-specific filtering.
Result<uint64_t> ReadManifestEntriesWithCache(
- const Snapshot& snapshot, const std::vector<ManifestFileMeta>&
bucket_manifest_metas,
- int32_t bucket, std::vector<ManifestEntry>* manifest_entries, bool*
cache_hit) const;
+ const Snapshot& snapshot, std::vector<ManifestFileMeta>*
all_manifest_metas,
+ std::vector<ManifestFileMeta>* filtered_manifest_metas, int32_t bucket,
+ std::vector<ManifestEntry>* manifest_entries, bool* cache_hit,
+ int64_t* all_data_files) const;
Review Comment:
Is `bucket` an input parameter? It looks like it’s currently placed with the
output parameters—please move it to the front.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
