wangyong9999 commented on code in PR #374:
URL: https://github.com/apache/paimon-cpp/pull/374#discussion_r4375491300
##########
src/paimon/core/operation/file_store_scan.h:
##########
@@ -289,8 +293,10 @@ class FileStoreScan {
/// Read request-filtered entries while caching complete bucket snapshots.
/// @return Number of entries considered before request-specific filtering.
Result<uint64_t> ReadManifestEntriesWithCache(
- const Snapshot& snapshot, const std::vector<ManifestFileMeta>&
bucket_manifest_metas,
- int32_t bucket, std::vector<ManifestEntry>* manifest_entries, bool*
cache_hit) const;
+ const Snapshot& snapshot, std::vector<ManifestFileMeta>*
all_manifest_metas,
+ std::vector<ManifestFileMeta>* filtered_manifest_metas, int32_t bucket,
+ std::vector<ManifestEntry>* manifest_entries, bool* cache_hit,
+ int64_t* all_data_files) const;
Review Comment:
Thanks, moved `bucket` before the output parameters in 728ed5b9. I also
checked the adjacent helpers and moved `apply_scan_filter` before the output in
`ReadFileEntries`, updating all callers. No behavior changes; full-tree
pre-commit and diff checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
