JingsongLi opened a new pull request, #1287:
URL: https://github.com/apache/paimon-rust/pull/1287

   ### Purpose
   
   Closes #1281.
   
   SQLContext rejects table COMMENT options and ALTER COLUMN COMMENT syntax 
even though Paimon's SchemaChange API already supports metadata comments.
   
   ### Brief change log
   
   - Persist table comments during CREATE TABLE and route COMMENT ON 
TABLE/COLUMN through existing SchemaChange APIs.
   - Parse ALTER TABLE ... ALTER COLUMN ... COMMENT using tokens, preserving 
literals and quoted identifiers.
   - Honor identifier normalization and table-only IF EXISTS semantics; reject 
temporary shadowing, unsupported modifiers and trailing statements.
   
   ### Tests
   
   - Regression coverage: Round-trip table/column comments, NULL removal, 
retained data and field IDs/types, quoted/case-sensitive names, missing 
objects, duplicate comments, branch targets, temporary shadowing and 
trailing-statement rejection.
   - Reproduced the missing behavior on the original main before implementation.
   - Passed the complete DataFusion suite with `TZ=UTC RUST_MIN_STACK=16777216 
CARGO_BUILD_JOBS=3 cargo test --locked -p paimon-datafusion --all-targets -- 
--test-threads=4`.
   - Passed Rust 1.98 Clippy for this crate and all its targets with `--no-deps 
-- -D warnings`, formatting and diff checks.
   
   ### API and Format
   
   Adds SQLContext SQL capabilities. No storage-format or Rust public API 
changes.
   
   ### Documentation
   
   Documented syntax, type/null/error behavior and supported limits in 
`docs/src/sql.md`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to