JingsongLi commented on code in PR #10985:
URL: https://github.com/apache/paimon/pull/10985#discussion_r4478839520


##########
paimon-core/src/test/java/org/apache/paimon/table/CsvSkipEmptyLinesTableTest.java:
##########
@@ -92,11 +92,14 @@ void testRejectedAsDynamicOptionOfFileStoreTable() throws 
Exception {
         // skipped while the file metadata still counts it.
         write(table, GenericRow.of((Object) null), GenericRow.of(1));
 
+        // Dynamic options are validated when the copied table creates its 
runtime scan.
         assertThatThrownBy(
                         () ->
                                 table.copy(
-                                        Collections.singletonMap(
-                                                
CsvOptions.SKIP_EMPTY_LINES.key(), "true")))
+                                                Collections.singletonMap(
+                                                        
CsvOptions.SKIP_EMPTY_LINES.key(), "true"))
+                                        .newReadBuilder()

Review Comment:
   [P2] Drop the duplicate CSV test commit after #10989 lands
   
   This hunk changes the same assertion as #10989, which also verifies that 
`Table.copy` itself succeeds. `git merge-tree` reproduced a content conflict 
between the two current heads in this test. Please rebase after #10989 and drop 
`1cc669bfd2` so this branch carries just the Vortex predicate fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to