zhouyc-ali commented on code in PR #10985:
URL: https://github.com/apache/paimon/pull/10985#discussion_r4488551759
##########
paimon-core/src/test/java/org/apache/paimon/table/CsvSkipEmptyLinesTableTest.java:
##########
@@ -92,11 +92,14 @@ void testRejectedAsDynamicOptionOfFileStoreTable() throws
Exception {
// skipped while the file metadata still counts it.
write(table, GenericRow.of((Object) null), GenericRow.of(1));
+ // Dynamic options are validated when the copied table creates its
runtime scan.
assertThatThrownBy(
() ->
table.copy(
- Collections.singletonMap(
-
CsvOptions.SKIP_EMPTY_LINES.key(), "true")))
+ Collections.singletonMap(
+
CsvOptions.SKIP_EMPTY_LINES.key(), "true"))
+ .newReadBuilder()
Review Comment:
Rebased onto master after #10989 and dropped `1cc669b`. The PR now contains
only the Vortex fix and its tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]