QuakeWang commented on code in PR #1306:
URL: https://github.com/apache/paimon-rust/pull/1306#discussion_r4490206094


##########
bindings/c/src/write.rs:
##########
@@ -571,6 +571,27 @@ pub unsafe extern "C" fn 
paimon_postpone_fixed_bucket_write_builder_new_write(
     }
 }
 
+/// Close a standard TableWrite, discarding unprepared output on a best-effort 
basis.

Review Comment:
   [P2] Document that close may flush buffered output
   
   Please clarify that `close()` may finish and upload buffered output before 
attempting deletion. The append path calls `writer.close().await` during abort, 
so callers cannot rely on this API for cancellation without flushing. The 
current text explains cleanup failures but omits this I/O behavior. A 
documentation clarification is sufficient for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to