JingsongLi commented on code in PR #1306:
URL: https://github.com/apache/paimon-rust/pull/1306#discussion_r4478953985
##########
bindings/c/src/write.rs:
##########
@@ -571,6 +571,26 @@ pub unsafe extern "C" fn
paimon_postpone_fixed_bucket_write_builder_new_write(
}
}
+/// Close a standard TableWrite, discarding outstanding output without
preparing a commit.
Review Comment:
[P2] Document the I/O and failure semantics of close
#1302 asks for cancellation without flushing unprepared output. This wrapper
calls `TableWrite::close()`, whose append path finishes the active Parquet
writer before attempting to delete its file. Cleanup errors are discarded by
core and the C function still returns success.
I reproduced this via the C write and close APIs with an instrumented
storage provider. The unprepared object was absent before close. Close wrote it
and then attempted deletion. With an injected deletion denial, close returned
null and the object remained. With successful deletion, it disappeared. In both
runs, the previously prepared message still committed and only its row was
visible.
Please describe this API as best-effort cleanup that can finish and upload
buffered output and that does not report storage cleanup errors. If
cancellation without flushing is required for #1302, it needs a separate core
abort path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]