lszskye commented on code in PR #516: URL: https://github.com/apache/paimon-cpp/pull/516#discussion_r4488567841
########## src/paimon/core/table/table.cpp: ########## Review Comment: Since the branch is already stored in CoreOptions, could FileStore derive it from options_.GetBranch()? Passing it separately seems redundant and allows the two values to diverge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
