lszskye commented on code in PR #516:
URL: https://github.com/apache/paimon-cpp/pull/516#discussion_r4488664108


##########
src/paimon/core/table/table.cpp:
##########
@@ -590,23 +563,20 @@ class TableScanImpl {
         const std::shared_ptr<Executor>& executor, const 
std::shared_ptr<MemoryPool>& memory_pool,
         const ScanContext* context) {
         auto fs = core_options.GetFileSystem();
-        auto manifest_file_format = core_options.GetManifestFormat();
         std::string branch = 
BranchManager::NormalizeBranch(core_options.GetBranch());
-        auto snapshot_manager = std::make_shared<SnapshotManager>(fs, 
context->GetPath(), branch);
+        FileStore file_store(context->GetPath(), branch, core_options);
+        PAIMON_ASSIGN_OR_RAISE(std::shared_ptr<SnapshotManager> 
snapshot_manager,
+                               file_store.NewSnapshotManager(nullptr, 
std::nullopt));

Review Comment:
   please add comment for `nullptr` and `std::nullopt`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to