LuciferYang opened a new pull request, #11028:
URL: https://github.com/apache/paimon/pull/11028

   ### Purpose
   
   close #11027
   
   `create_table` accepted a partition or primary key that is not a column, and 
the persisted table could then neither be loaded nor dropped. It also accepted 
duplicate column names and duplicate keys.
   
   `SchemaManager.create_table` now runs the checks Java's `Schema` runs on 
creation, with the same messages: column names must be unique, and partition 
and primary keys must not repeat and must be columns. `FileSystemCatalog` and 
`JdbcCatalog` create tables through it, so nothing is written for a rejected 
schema. Existing tables are not checked when they are loaded.
   
   ### Tests
   
   `TestColumnAndKeyValidation` in `schema_manager_test.py`, failing on master:
   
   - A partition key or primary key that is not a column is rejected, and the 
table name can still be used.
   - Duplicate column names, partition keys and primary keys are rejected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to