LuciferYang commented on code in PR #11028:
URL: https://github.com/apache/paimon/pull/11028#discussion_r4509270363


##########
paimon-python/pypaimon/schema/schema_manager.py:
##########
@@ -747,6 +747,30 @@ def _validate_primary_key_blob_fields(
         )
 
 
+def _duplicates(names: List[str]) -> List[str]:

Review Comment:
   Changed to a `Counter` in 0fd64d5bd1. A 10,000-column list with no 
duplicates now takes about 1 ms here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to