HaHaJeff commented on code in PR #525:
URL: https://github.com/apache/paimon-cpp/pull/525#discussion_r4502136883


##########
src/paimon/core/utils/primary_key_table_utils.cpp:
##########
@@ -103,13 +103,15 @@ Status 
PrimaryKeyTableUtils::ValidateRealtimeOptions(const CoreOptions& options,
     if (options.GetBucket() <= 0) {
         return Status::NotImplemented("PK realtime requires fixed buckets");
     }
-    if (options.GetMergeEngine() != MergeEngine::DEDUPLICATE) {
-        return Status::NotImplemented("PK realtime supports only the 
DEDUPLICATE merge engine");
+    if (options.GetMergeEngine() != MergeEngine::DEDUPLICATE &&
+        options.GetMergeEngine() != MergeEngine::PARTIAL_UPDATE) {
+        return Status::NotImplemented(
+            "PK realtime supports only the DEDUPLICATE and PARTIAL_UPDATE 
merge engines");

Review Comment:
   I've disabled realtime partial-update with deletion vectors for now to keep 
this PR scoped. The ordinary Writer path and realtime deduplicate with DVs 
remain unchanged. Support for this combination can be added separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to