HaHaJeff commented on code in PR #525:
URL: https://github.com/apache/paimon-cpp/pull/525#discussion_r4509384494


##########
src/paimon/core/utils/primary_key_table_utils.cpp:
##########
@@ -103,13 +103,20 @@ Status 
PrimaryKeyTableUtils::ValidateRealtimeOptions(const CoreOptions& options,
     if (options.GetBucket() <= 0) {
         return Status::NotImplemented("PK realtime requires fixed buckets");
     }
-    if (options.GetMergeEngine() != MergeEngine::DEDUPLICATE) {
-        return Status::NotImplemented("PK realtime supports only the 
DEDUPLICATE merge engine");
+    if (options.GetMergeEngine() != MergeEngine::DEDUPLICATE &&
+        options.GetMergeEngine() != MergeEngine::PARTIAL_UPDATE) {

Review Comment:
   The scan now skips value-stats pruning only for realtime partial-update, 
while keeping key filtering. I extended the existing integration test to verify 
the merged row and value predicates before commit and after reopening.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to