SteNicholas commented on PR #1313:
URL: https://github.com/apache/paimon-rust/pull/1313#issuecomment-6600448595

   @JingsongLi, done in 38e6458. `PyReadBuilder` no longer caches 
`unresolved_selector`: `new_scan()`, and `new_incremental_scan()` through it, 
reads the selector from `table.schema().options()` and passes when 
`table.has_resolved_travel_snapshot()` is true, while `new_stream_scan()` still 
lets the stream scan resolve its own start.
   
   One adjustment: `has_resolved_travel_snapshot()` is also false for a table 
that never went through `copy_with_time_travel`, such as a 
`Table.from_resolved_schema` / `copy_with_resolved_schema` table or a catalog 
table with a persisted `scan.snapshot-id` or `scan.tag-name`, whose selector 
the core resolves at plan time (`test_resolved_table.py` reads such tables 
through `new_read_builder().new_scan()`). Failing on that state alone would 
reject them, so when a selector is set but not yet resolved, `new_scan()` calls 
`table.resolve_read_snapshot()`, the same resolution the plan runs, and raises 
only if it fails. Only that case does IO; a table without a selector, or with a 
resolved one, is checked from state alone. `test_resolved_table.py` now also 
covers a resolved-schema selector that matches no snapshot.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to