SteNicholas commented on code in PR #1313:
URL: https://github.com/apache/paimon-rust/pull/1313#discussion_r4450962787


##########
bindings/python/python/pypaimon_rust/datafusion.pyi:
##########
@@ -469,6 +469,14 @@ class Table:
     def schema(self) -> TableSchema: ...
     def new_system_read(self, name: str) -> SystemRead: ...
     def new_read_builder(self, options: Optional[Dict[str, str]] = None) -> 
ReadBuilder: ...
+    def new_stream_read_builder(self, options: Optional[Dict[str, str]] = 
None) -> ReadBuilder:

Review Comment:
   @JingsongLi, agreed. The separate builder only existed because the binding's 
`new_read_builder(options)` raised when a time-travel selector resolved to no 
snapshot, which rejected valid stream starts (the next commit, an expired 
snapshot, an early timestamp, an empty table). Removed 
`new_stream_read_builder` in 38e6458: `new_read_builder(options)` now defers 
that check to the batch `new_scan()` / `new_incremental_scan()`, so 
`table.new_read_builder(options).new_stream_scan()` works as Java's 
`table.copy(options).newReadBuilder().newStreamScan()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to